Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype Account button and Popover #1230

Closed
wants to merge 23 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
b52fe87
MainWindow: Add an account button, comment out some bullshit
cassidyjames Mar 12, 2020
bd75cdb
MainWindow: More style finagling
cassidyjames Mar 12, 2020
a34f775
Add basic dialog with app listbox
cassidyjames Mar 12, 2020
33c7ce2
Make dialog modal and give it a top-level window
cassidyjames Mar 12, 2020
69cc01f
Lint
cassidyjames Mar 12, 2020
3c4db80
Remove unused CSS
cassidyjames Mar 12, 2020
bf07913
DRY title
cassidyjames Mar 12, 2020
b63c620
RY title because apparently that didn't work
cassidyjames Mar 12, 2020
8c7c651
MainWindow: Add account popover
cassidyjames Mar 13, 2020
c0ebac9
Update copyright headers
cassidyjames Mar 13, 2020
77bf001
Fix CSS indentation
cassidyjames Mar 13, 2020
bd9137f
Fix CSS indentation
cassidyjames Mar 13, 2020
6ab7029
AppHistoryDialog: Open AppStream link on activating row
cassidyjames Mar 13, 2020
04076f5
Try to get activating on single click
cassidyjames Mar 13, 2020
40c2dd3
Fix single-click activation
cassidyjames Mar 13, 2020
dcce5b3
Add filter checkbox
cassidyjames Mar 13, 2020
477bfdb
Fix keyboard spam
cassidyjames Mar 13, 2020
64bbb09
Merge branch 'master' into prototype-library
cassidyjames Mar 28, 2020
21d28f3
Merge branch 'master' into prototype-library
cassidyjames Apr 19, 2020
3ae1299
Merge branch 'master' into prototype-library
cassidyjames Feb 11, 2021
ad58742
AppHistoryDialog: Subclass Granite.Dialog
cassidyjames Feb 11, 2021
4a0bc9c
Bump copyrights
cassidyjames Feb 11, 2021
7f9cc28
Remove custom styling for badge
cassidyjames Feb 11, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix single-click activation
cassidyjames committed Mar 13, 2020
commit 40c2dd3c1a06613bfb6cafb4f6946e8b1fb2ada5
5 changes: 5 additions & 0 deletions src/Dialogs/AppHistoryDialog.vala
Original file line number Diff line number Diff line change
@@ -89,6 +89,11 @@ public class AppCenter.Widgets.AppHistoryDialog : Gtk.Dialog {
get_content_area ().add (grid);
add_button (_("Cancel"), Gtk.ResponseType.CANCEL);

list_box.row_activated.connect ((row) => {
(row as Widgets.AppHistoryRow).open_app ();
destroy ();
});

response.connect (() => {
destroy ();
});
14 changes: 7 additions & 7 deletions src/Widgets/AppHistoryRow.vala
Original file line number Diff line number Diff line change
@@ -56,13 +56,13 @@ public class AppCenter.Widgets.AppHistoryRow : Gtk.ListBoxRow {
grid.attach (description_label, 1, 1);

add (grid);
}

activate.connect (() => {
try {
AppInfo.launch_default_for_uri ("appstream://%s".printf (rdnn), null);
} catch (Error e) {
critical (e.message);
}
});
public void open_app () {
try {
AppInfo.launch_default_for_uri ("appstream://%s".printf (rdnn), null);
} catch (Error e) {
critical (e.message);
}
}
}