Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage: fixed infinte loop if candidate_package = null #158

Merged
merged 4 commits into from
Mar 24, 2017
Merged

Homepage: fixed infinte loop if candidate_package = null #158

merged 4 commits into from
Mar 24, 2017

Conversation

GiltosMx
Copy link
Contributor

No description provided.

tintou
tintou approved these changes Mar 24, 2017
View reviewed changes
Copy link
Member

@tintou tintou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, foreach are better than while when it's available

tintou
tintou previously requested changes Mar 24, 2017
View reviewed changes
Copy link
Member

@tintou tintou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, shouldn't the line
i = newest_ids.length;
be replaced by a break; ?

@donadigo
Copy link
Contributor

@tintou is right. You should break instead of going further.

@GiltosMx
Copy link
Contributor Author

Done, you're right, missed it. I think it's fixed now, let me know if anything else comes up.

@danirabbit danirabbit dismissed tintou’s stale review March 24, 2017 23:33

Mobile, but he said it was okay

@danirabbit danirabbit merged commit bf4730a into elementary:master Mar 24, 2017
@danirabbit danirabbit mentioned this pull request Mar 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

@tintou tintou tintou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GiltosMx @donadigo @tintou @danirabbit