Use libical timezones where possible #675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops--I pushed the wrong branch. TIL don't keep 2 nearly identically named branches around. I'll open a new one with the correct branch... 😬 The new branch is based on #653 though (for testing framework), so I'll have to wait until that is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #572 (and maybe others?)
Initially discussed in #660
This is going to be part 1.
I removed all the
GLib.TimeZonelogic that I could and instead used libical functions. This should solve issues with unrecognized timezones, since every event has a timezone that is defined within libical. For example, it will solve #572 because it doesn't need to map the timezone in libical's data to a GLib.TimeZone, which was failing.As discussed on Slack, I plan to remove as many instances of GLib.DateTime as possible in a future PR in favor of using ICal.Time throughout the codebase. But I think that this is a mostly complete and self-contained change, so to break it up as much as possible I'm submitting it as its own PR.