Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change panel menu items to linkbutton #1223

Merged
merged 9 commits into from
Jan 13, 2023
Merged

Change panel menu items to linkbutton #1223

merged 9 commits into from
Jan 13, 2023

Conversation

danirabbit
Copy link
Member

Fixes #1213

Screenshot from 2023-01-09 13 16 25

  • Make toggle actions hold their state
  • Change tooltips to reflect show/hide action
  • Use linked icon togglebuttons to show/hide panels

@danirabbit danirabbit requested a review from a team January 9, 2023 21:37
@jeremypw
Copy link
Collaborator

@danirabbit Please could you resolve conflicts? Thanks.

@danirabbit
Copy link
Member Author

@jeremypw fixed!

@danirabbit danirabbit mentioned this pull request Jan 10, 2023
Merged
jeremypw
jeremypw requested changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small simplification suggested inline, otherwise looks good

src/MainWindow.vala Show resolved Hide resolved
@danirabbit danirabbit requested a review from jeremypw January 12, 2023 21:31
@jeremypw jeremypw merged commit 3eb601c into master Jan 13, 2023
@jeremypw jeremypw deleted the panels-linkbutton branch January 13, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wording issues when translating to french
2 participants
@danirabbit @jeremypw