Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application: use built-in GLib functions in Activate #1243

Merged
merged 4 commits into from
Jan 23, 2023

Conversation

danirabbit
Copy link
Member

No description provided.

@danirabbit danirabbit requested a review from jeremypw January 14, 2023 20:48
@Marukesu
Copy link
Contributor

Note that this has a little change in multiple windows behaviour, get_last_window() always return the last created window, while active_window is the last interacted window.

So, when there's two or more windows, the old code use the more recent open, but the new code will use the more recent focused.

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changed behaviour is not unreasonable and anyway only affects a corner case.

@danirabbit danirabbit merged commit 96bc1ca into master Jan 23, 2023
@danirabbit danirabbit deleted the application-activateglib branch January 23, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants