-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure folder items in sidebar always expandable #1252
Conversation
Finally getting to look at this. Code looks good, I just gotta test it. |
When I loaded a folder with a mix of file and folders (the source folder for Code), I noticed non-text files in the build/src directory weren't visible and when I removed what was there, the dummy was not created and thus would not let you expand it. If I restored the deleted files it immediately detected and was expandable. In my test with fresh new folders, adding and removing things would properly keep the expand functionality. Not sure what is different. |
Just looked at it again after realizing I was running it from the build directory instead of installing it. If I Install it works correctly! |
It should not matter whether running installed or not (as long there isnt a pre-existing master version running) as no plugins are involved. You can verify which version is running by using |
Fixes #739
Needed to relation to issues with expanding and closing folders in the sidebar as well as accomodating files being added removed and renamed while correctly handling presence/absence of dummy item. The behaviour of the sidebar is now similar to that of Files in relation to empty folders.
Test by creating a project with a mixture of subfolders - empty, only non-text files, text files. Add, remove, rename files in each case to check correct behaviour.