-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically update word completions #1491
base: master
Are you sure you want to change the base?
Conversation
… completion plugin The 'insert_text' signal gives more detail about how the document contents have changed, giving us a way to more accurately update the prefix tree used for word completion
…dded. Not just one character
…boundaryto the Word Completion plugin
* Detect when cursor moves off insertion line
Flatpak CI failing due to Gnome Gitlab outage. |
I'm going to dog-food this for a while before asking for reviews. |
@colinkiama If you have time to try and break this I would be grateful! The logic is quite involved so it is hard to be sure it copes with all circumstances. |
At the moment this only works reliably in OS7.1. There are some weird bugs when running it on OS8 inside a Gnome Boxes VM. Not sure why - maybe a timing thing? Converting back to draft while investigating. |
Based on #1487
split-set
with custom delimiters to identify words (do not use textiter functions)For simplicity, insertions and deletions are all handled the same way rather than separate functions depending on where the insertion/deletion occurred. This results in some temporary "words" being added and removed in quick succession while typing but on current average hardware (i5 processor, SSD) and modest sized files (3000 lines) no performance issues were noticed. However, more efficiency could be achieved at the cost of greater complexity by queueing the changes (like Files) and ignoring those that cancel out.
To be decided: