Update prepare-code-for-review.md (#8)

* Update prepare-code-for-review.md * Update development/prepare-code-for-review.md Co-authored-by: Corentin Noël <[email protected]> * Update prepare-code-for-review.md Co-authored-by: Corentin Noël <[email protected]>
elementary · Nov 11, 2021 · 114253f · 114253f
1 parent 9ed2193
commit 114253f
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/development/prepare-code-for-review.md b/development/prepare-code-for-review.md
@@ -12,7 +12,13 @@ If it's not obvious, it can also be helpful to include instructions on how to te
 
 ## Review Your Own Branch
 
-When you have your initial version for the proposed change working, look at your changes once again and ask yourself if anything could be improved before marking it "Ready for Review".
+When you have your initial version for the proposed change working, look at your changes once again and ask yourself if anything could be improved before marking it "Ready for Review". Be sure to check that:
+
+✅️ Your branch adheres to the elementary [code style guide](https://docs.elementary.io/develop/writing-apps/code-style)
+
+✅️ No New Terminal warnings are introduced
+
+✅️ Your branch passes required [status checks](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks)
 
 {% hint style="info" %}
 If you need help or your branch isn't quite ready for review, you can open a Draft pull request and convert it to "Ready for Review" later