Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose OS-wide dark style preference #277

Closed
wants to merge 4 commits into from
Closed

Conversation

cassidyjames
Copy link
Contributor

@cassidyjames cassidyjames commented Mar 12, 2019

Will fix #276. Right now this is just a method that returns a bool, but I imagine it'd be more useful to be able to bind to this. Updated to be a property. Not sure where it would belong though. Feedback welcome.

@cassidyjames cassidyjames requested a review from danirabbit March 12, 2019 05:25
@worldofpeace
Copy link

If the GSetting schema that contains the setting does not

  • exist, this will not connect and cb will never be called.

But because the GSettings Schema is provided by switchboard-plug-pantheon-shell it creates a circular cycle between granite.

It shouldn't cause a failure because of the precaution, but it would be a good practice to avoid that entirely.

@cassidyjames
Copy link
Contributor Author

@worldofpeace yeah I suppose in this case Granite could create the GSettings Schema itself?

@donadigo
Copy link
Collaborator

@cassidyjames in my opinion ideally for such a setting, no non-core / exclusive package should manage how this setting is created. The setting should be created and built-in on an OS level (e.g. at install). This ensures that we don't add any unnecessary dependencies.

@worldofpeace
Copy link

@worldofpeace yeah I suppose in this case Granite could create the GSettings Schema itself?

There's a similar problem with #242 and @danrabbit said that didn't belong in granite either.
Seemed we mostly agreed on there being an elementary-desktop-schemas.

I think we should go with that.

@cassidyjames
Copy link
Contributor Author

Closing in favor of #319

@cassidyjames cassidyjames deleted the prefer-dark branch September 14, 2019 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add way to check if the OS prefers a dark style
3 participants