Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Contractor and re-organize #33

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Remove Contractor and re-organize #33

merged 2 commits into from
Dec 9, 2022

Conversation

danirabbit
Copy link
Member

AFAIK, it's not possible for Flatpak apps to read contract files, so this is kind of irrelevant now

Also removed the "Desktop Integration" page since it's mainly fluff

@danirabbit danirabbit requested a review from cassidyjames March 24, 2021 19:52
@cassidyjames
Copy link
Contributor

@danrabbit can Flatpak apps still provide Contracts, though, e.g. so they show up in Files or Code? If not, do we have a recommended replacement for that?

I guess this and elementary/settings-daemon#34 also raises the question: is the HIG only for third-party developers? If so, how/where should we document best practices for first-party things?

@danirabbit
Copy link
Member Author

danirabbit commented Mar 24, 2021

@cassidyjames AFAIK, no they can't. The replacement is to pursue adding a mediatype parameter to the app launcher actions spec. But apps in Flatpak can't even list other apps for like an "Open With" menu, IIRC. So we need some kind of portal with a share sheet type of thing to even have that functionality.

Since the plan is to Flatpak All The Things, we'll have to deal with these same issues in our first party apps as well, so I'm not sure there's really a strong distinction there

@hanaral
Copy link

hanaral commented May 14, 2021

I'd like to note that many apps such as code (assuming it will be flatpak'ed) have context menu items for 'Open in X', so whatever it is replaced with needs to be just as intuitive and performant. There is also the worry that it will place a barrier for quickly judging which type of app can open an item, since it will be another layer of interface before you can see what's available.
I've opened a relevant issue regarding this problem under settings daemon

@Marukesu
Copy link

AFAIK, it's not possible for Flatpak apps to read contract files, so this is kind of irrelevant now

Well, they can, they only need to add --talk-name=org.elementary.Contractor to finish args.

We can also add a portal to copy the sandboxed contract to the host path so they can be used on others apps.

@danirabbit danirabbit merged commit 872fea6 into master Dec 9, 2022
@danirabbit danirabbit deleted the no-contractor branch December 9, 2022 18:18
ryonakano added a commit to elementary/docs that referenced this pull request Mar 19, 2024
danirabbit pushed a commit to elementary/docs that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants