Actions: Update open-menu and system-run borders #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
requested changes
Jun 19, 2023
Use semi-transparent borders on the "gear" icons to give them a sharper look, especially in dark themes.
Add system-run at 16px and 32px. Fix missing highlight in 24px open-menu.
Ah, I did miss that highlight! Good catch! Thanks! Fixed that and added the other sizes. I had to force push (maybe because I amended my second commit after committing it?). Hope that doesn't cause any problems. Let me know if anything else needs to be adjusted or anything. Thanks! |
danirabbit
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use semi-transparent borders on the "gear" icons to give them a sharper look, especially in dark themes.
I have
system-runin 16px and 32px, but wasn't sure if they're wanted/needed. I have seen the 16px size used in other non-elementary apps. If that's something you all would like let me know and I'll update this PR. Here's the icon for reference.