Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Colorize font formatting icons at 16px #1289

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

newhoa
Copy link
Collaborator

@newhoa newhoa commented Jun 9, 2024

Colorize font formatting icons for better visibility under dark themes. Use semi-transparent borders,
Update font to Inter-V.

Add missing FD.o icons format-text-direction-*


Initial proposal on these, feedback would be appreciated.

Questions

  1. Should this also be done for the existing 24px icons, or are they even needed? (I really see almost no places where these are used anyway)
  2. Would it be better to use B I U and S, which have become more common in editors, chat programs, etc. These are also currently used for the symbolic icons.

Thanks.

Colorize font formatting icons for better visibility
under dark themes. Use semi-transparent borders,
Update font to Inter-V.
@micahilbery
Copy link
Member

I think it would be better to use B, U, and S. I think the a (a, a, a) alone is harder to understand for english speakers where those things start with those letters and no more clear for non-english speakers. Also the consistency with the symbolics is a good thing as well.

@newhoa newhoa marked this pull request as draft September 18, 2024 21:57
@newhoa newhoa marked this pull request as draft September 18, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants