Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression: Make sure we show composer if session was already started #724

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Fix regression: Make sure we show composer if session was already started #724

merged 1 commit into from
Oct 18, 2021

Conversation

marbetschar
Copy link
Member

This PR f*xes the issue described by @Marukesu here. This regression was introduced by #718

@marbetschar marbetschar requested a review from Marukesu October 18, 2021 06:20
@marbetschar marbetschar changed the title Fix regression: Make sure we show composer is session was already started Fix regression: Make sure we show composer if session was already started Oct 18, 2021
jeremypw
jeremypw approved these changes Oct 18, 2021
View reviewed changes
Copy link

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm it fixes the problem with the Files plugin - thanks!

@jeremypw jeremypw merged commit 4f76ab6 into master Oct 18, 2021
@jeremypw jeremypw deleted the fix-wait-for-session-start branch October 18, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

@Marukesu Marukesu Awaiting requested review from Marukesu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marbetschar @jeremypw