-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use subject for window title of new message window #747
Merged
danirabbit
merged 11 commits into
master
from
use-subject-for-window-title-of-new-message-window
Jan 11, 2022
Merged
Use subject for window title of new message window #747
danirabbit
merged 11 commits into
master
from
use-subject-for-window-title-of-new-message-window
Jan 11, 2022
+26
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalmbach
reviewed
Jan 7, 2022
kalmbach
reviewed
Jan 7, 2022
@kalmbach thank you for your review. Really helpful comments 😊 |
Tested! Works smoothly. Nice work! |
danirabbit
requested changes
Jan 11, 2022
Co-authored-by: Danielle Foré <[email protected]>
danirabbit
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
danirabbit
deleted the
use-subject-for-window-title-of-new-message-window
branch
January 11, 2022 21:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #745
Screen_record_from_2021-12-23_08.19.29.mp4