-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BGRT Plymouth theme #4
Conversation
When updating the initramfs with
So the theme is not installed. Ubuntu 20.04.1This works with Ubuntu 20.04.1. Plymouth related installed packages:
elementary OS 6 daily
|
UpdateMissing library is provided by Reference: https://packages.ubuntu.com/focal-updates/amd64/plymouth-theme-spinner/filelist |
@cassidyjames the animated spinner is a series of PNGs. How is elementary's spinner created? Pure CSS? Could we export it as single PNGs? We have to play a bit with size of elementary's logo. Ubuntu's logo is 248 x 49. I resized elementary's logo to 64 x 64. |
@meisenzahl honestly I'm wondering if we just drop the elementary logo from here. This screen is typically short-lived, and I don't want to over-brand it with competing logos. Regarding the spinner, there is @elementary/icons/status/symbolic/process-working-symbolic, which we could recolor to white and export different states. How many images do you need? @danrabbit thoughts on both of the above? |
@cassidyjames I would also have no problem removing the elementary logo. The screen looks a bit overloaded. We need one image for each frame of the animation. We might have to resize it a bit. The Ubuntu images are 38 x 38. |
@cassidyjames thank you for providing the images. |
How do we package it? We need |
We can test this on Raspberry Pi. UpdateAs expected, the center simply remains empty if no logo can be extracted from the firmware. This happens with all ARM and older x86 devices. |
@meisenzahl I really like how minimal this is. We should probably decide/test some things before merging:
Anything else I'm missing? |
I created a Merge Request for Plymouth: |
Regarding the password prompt we could provide our own
The progress bar is drawn without assets. |
@meisenzahl I updated my comment above, but I think the main thing blocking this now is documenting how to install/test it on elementary OS 6. |
Co-authored-by: Cassidy James Blaede <[email protected]>
I can confirm that the debian packaging works as expected. When installing the deb built from this branch, it correctly pulls in the Even when forcibly re-installing the |
While I'm happy with these changes technically and have tested that the debian packaging works, the current We can see the source of the plymouth theme here: I think if we set up a launchpad recipe for this repo, and updated the debian changelog here so that the version of this was newer than the one from default settings (currently 5.1.2), this would supersede the one from default-settings. Then we could remove that from the packaging there. I feel it makes sense for this to be in its own separate repo, but it's just a bit fiddly to swap the debian package over. |
@danrabbit and/or @tintou could you look into that? ^ |
I've updated the debian packaging and added a breaks/replaces of the current version of elementary-default-settings. |
Some files have been taken from elementary-default-settings so only allow to install if we have the updated version.
c2d02a3
to
048dda5
Compare
I suggest that we first merge #7. This way we do not pollute the Git history with the png files. @cassidyjames do we want to transfer the explanations in the README to the Wiki? |
@meisenzahl I'm indifferent; the README is fine to me |
The feature was recently merged. I created an issue to deploy the latest version of Plymouth. @cassidyjames while we are here: can you provide a version of elementary's logo as fallback image for ARM based devices? It has to be located in |
@meisenzahl reusing https://github.com/elementary/plymouth-theme/blob/master/elementary/logo.png seems to make the most sense to me |
@meisenzahl I think I'd rather get this merged sooner instead of it being blocked forever. |
Closes #3