Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to grab modes #155

Closed
wants to merge 2 commits into from

Conversation

mcclurgm
Copy link

@mcclurgm mcclurgm commented Mar 23, 2020

Fixes elementary/portals#106.

Before:
Screenshot from 2020-03-23 15 48 10
After:
screenshot-labels

This adds labels to the radio buttons that set the grab mode. I've tried to be as concise as possible, so the window layout can be as similar to the current implementation as possible. The copy may need design. Of course, it's also possible that there needs to be more design work in general, and if we want to add labels we can't keep the original layout at all. I think this is enough, though.

This needs some work though. The selected styling doesn't apply once I add a label to the buttons, and of course I think we will still want that. I'm not sure how to solve this, since it seems like the selected style isn't defined in the screenshot project itself.

@danirabbit
Copy link
Member

Closing since the screenshot window is now provided by the portal, sorry for missing this previously!

@danirabbit danirabbit closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label the selection modes
2 participants