Port SettingsDaemon.Application to Gtk.Application
#81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gtk.Application has session registration capabilities already, so let's use it. while here, add the IS_SERVICE and ALLOW_REPLACEMENT flags to the application, so we don't need to implement activate() and have a way to replace the running session during development. the setup_accounts_services() method was also rewritten to not call org.freedesktop.Accounts.FindUserByName excessively. Signed-off-by: Gustavo Marques <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gtk.Application has session registration capabilities already, so let's use it.
While here, add the
IS_SERVICEandALLOW_REPLACEMENTflags to the application, so we don't need to implementactivate()and have a way to replace the running session during development.the
setup_accounts_services()method was also rewritten to not call org.freedesktop.Accounts.FindUserByName excessively.