Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appearance: GTK4 prep #384

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Appearance: GTK4 prep #384

merged 3 commits into from
Jan 10, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 9, 2024 •
edited
Loading

Changes from #377

Screenshot from 2024-01-09 12 44 29

  • Use light/dark style images from Onboarding and use your wallpaper
  • Create them in a way that's more compatible with GTK 4 and relying on CSS for sizing
  • Replace grid with box
  • set mnemonic widget

@danirabbit danirabbit requested a review from a team January 9, 2024 20:28
jeremypw
jeremypw requested changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The background does not reflect truth if the user is using a plain color wallpaper rather than an image.

@danirabbit
Copy link
Member Author

@jeremypw ah yup. I'll revert the wallpaper part for now and follow up in another branch so I'm not blocking with that

@danirabbit danirabbit requested a review from jeremypw January 10, 2024 17:39
@jeremypw jeremypw merged commit 877c08e into master Jan 10, 2024
4 checks passed
@jeremypw jeremypw deleted the danirabbit/appearance-gtk4prep branch January 10, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw