-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fwupd #150
Conversation
…oard-plug-about into add-support-for-fwupd
…oard-plug-about into add-support-for-fwupd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something I noticed is that this introduces a significant lag when first opening the page. There are probably some operations that need to be made asynchronous from the view construction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last few comments
I'm getting a real big lag when first opening the System plug again :( |
@danrabbit ah, oops, I wonder if that's related to my merge earlier. Does it go away if you install |
@davidmhewitt ah yup, I think that's it. Created #171 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the code, but I have not conducted any testing. Nice work @meisenzahl !
@davidmhewitt thank you for your reviews and constructive feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the testing I've done, I'm happy with this as an MVP. I think we can wait until follow ups to iterate on the design and add features. But this does the thing as far as I'm concerned:)
I created some issues:
Feel free to create some more if I missed something :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #123