Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppSettingsView: DRY row creation #218

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Mar 27, 2024

Eventually serves #217 where I want these kind of rows using a different permissions backend

Can be rebase merged

@danirabbit danirabbit marked this pull request as ready for review March 27, 2024 17:49
@danirabbit danirabbit requested a review from a team March 27, 2024 17:50
danirabbit added a commit that referenced this pull request Mar 27, 2024
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Just one comment on decision I don't like.

@danirabbit
Copy link
Member Author

@lenemter no problem. reverted!

Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The last item in the permissions list has additional bottom margin

@danirabbit
Copy link
Member Author

@lenemter fixed!

Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@danirabbit danirabbit merged commit 7a15d3c into main Mar 29, 2024
1 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/appsettingsview-refactor branch March 29, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants