Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MainView: use bind_with_mapping to set auto icon #120

Merged
merged 3 commits into from
Feb 11, 2024
Merged

MainView: use bind_with_mapping to set auto icon #120

merged 3 commits into from
Feb 11, 2024

Conversation

danirabbit
Copy link
Member

Bind properties with mapping instead of creating a class-wide property

@danirabbit danirabbit requested a review from a team February 10, 2024 20:19
jeremypw
jeremypw approved these changes Feb 11, 2024
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, works as expected

@jeremypw jeremypw merged commit 9236206 into main Feb 11, 2024
3 of 4 checks passed
@jeremypw jeremypw deleted the danirabbit/mainview-autoicon-bindwithmapping branch February 11, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw