Fix Mail setup #184
Merged
Fix Mail setup #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the code in evolution we need 3 sources in order to sucessfully configure a mail account: https://gitlab.gnome.org/GNOME/evolution/-/blob/master/src/mail/e-mail-config-summary-page.c#L695-698
danirabbit
approved these changes
Jun 4, 2021
There was a problem hiding this comment.
This looks good! Nice job finding the obvious error with the real name as well 😅
I'm still having trouble with the saved password in the flatpak, but this does seem to work for native mail. I wonder if there's a dbus interface we're missing that we need to add to the Mail sandbox
|
maybe @Marukesu can help out regarding a potentially missing interface for Mail in the Flatpak build? Any idea what might cause the password not be saved in the Flatpak version? |
|
eds use libsecret to read/save passwords, because we are on a sandbox, libsecret try to get them from a file on the sandbox instead of the DBus Interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Mail setup in Online Accounts by introducing two changes:
According to the code in Evolution, we need 3 sources to completely configure a mail account. Until now we only used two. The first commit of this PR fixes this. This potentially fixes #172 as well, can you please verify @danrabbit?
The change handler was simply never executed in code if the user did not change the name - therefore the passed string was never set. The commit changes this by setting the initial state to the correct value.