Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallpaper: Confirm wallpaper removal when hidden #359

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Wallpaper: Confirm wallpaper removal when hidden #359

merged 2 commits into from
Jun 28, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Jun 28, 2023 •
edited
Loading

When you remove a wallpaper and immediately close the switchboard, the wallpaper won't be removed. This PR fixes this.

@lenemter lenemter requested a review from a team June 28, 2023 16:31
jeremypw
jeremypw approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. The name confirm_removal is a bit misleading as it implies a dialog. Probably should be e.g. ensure_removal. However that is outside the scope of this PR I guess.

@danirabbit danirabbit merged commit 57445d8 into master Jun 28, 2023
@danirabbit danirabbit deleted the lenemter/fix-undo branch June 28, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lenemter @jeremypw @danirabbit