Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerManager: store devices in a liststore #254

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

danirabbit
Copy link
Member

Setting up for supporting devices being added and removed. This will support both #253 and eventually handling UPS devices

@danirabbit danirabbit requested a review from a team February 11, 2024 22:03
src/PowerManager.vala Outdated Show resolved Hide resolved
@danirabbit danirabbit requested a review from jeremypw February 13, 2024 18:27
@danirabbit
Copy link
Member Author

@jeremypw can I get a re-review :)

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and runs as expected for a laptop with one battery and no other battery devices. Unable to test in a more complex environment but no obvious flaws in the logic.

@danirabbit danirabbit merged commit b039773 into main Feb 16, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/powermanager-devicesliststore branch February 16, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants