Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainView: justify layout, space between sections #256

Merged
merged 8 commits into from
Feb 25, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Feb 13, 2024

Try to make this layout a bit less wacky and easier to maintain:

  • Put sections in their own grids and double space between sections
  • Justify layout of widgets and labels
  • Set mnemonic widget where possible (Some comboboxes will need this fixed when ported to dropdown)
  • Put infobar by the lid settings

Screenshot from 2024-02-13 11 34 43@2x

@danirabbit danirabbit requested a review from a team February 13, 2024 19:59
@jeremypw
Copy link
Collaborator

@danirabbit Could you resolve the conflict please?

@danirabbit
Copy link
Member Author

@jeremypw done!

jeremypw

This comment was marked as resolved.

@danirabbit

This comment was marked as outdated.

@danirabbit danirabbit requested a review from jeremypw February 22, 2024 19:07
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and appearance look good, but I am getting a system hang (unresponsive to keyboard and mouse) when the authentication dialog appears after selecting a lid close option. Not sure whether due to this PR though.

Update: It does not occur in main.

@danirabbit
Copy link
Member Author

@jeremypw this branch only touches layout code. There are no functional changes in this branch whatsoever

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis that it only affects layout, not function.

@jeremypw jeremypw merged commit 3332760 into main Feb 25, 2024
2 of 4 checks passed
@jeremypw jeremypw deleted the danirabbit/justify-layout branch February 25, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants