UnsafePasteDialog: use paste icon #639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The biggest change I would make here honestly is swapped the suggested action, to make it "easier" to do the safe thing. the idea is your eyes are drawn to that, and it should be safe to just click blindly. |
|
@jhaygood86 that's not really inside the scope of this PR. I'm only changing the icon here. But also, that would kind of go against our HIG and could lead to misclicks. We want to make sure the "Cancel" action is in a consistent place |
|
How about swapping the icons? Keep the alert icon as before and make the paste icon as the smaller overlay? |
|
For me, it makes the icon over-complicated and reduces the impact of the dialog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure if this is better or worse, but figured I'd throw it out there:
Before
AFTER