Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations error #2996

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Fix translations error #2996

merged 1 commit into from
Oct 7, 2022

Conversation

lewisgoddard
Copy link
Member

Fixes #2955

This pull request is ready for review.

@lewisgoddard lewisgoddard requested a review from danirabbit May 17, 2022 19:02
Copy link
Contributor

@larouxn larouxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable fix based on the error message. ✔️

The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

@lewisgoddard lewisgoddard requested a review from RMcNeely October 4, 2022 23:26
@RMcNeely
Copy link
Contributor

RMcNeely commented Oct 5, 2022

My understanding of #2955 is that this is a temporary fix that will last until November? I see no reason to delay this fix but that means we'll need another issue to set up ENV variables is that correct?

@RMcNeely RMcNeely merged commit e1f5077 into master Oct 7, 2022
@RMcNeely RMcNeely deleted the fix-2955 branch October 7, 2022 14:19
@lewisgoddard
Copy link
Member Author

lewisgoddard commented Oct 7, 2022

I think that is referring to November past, this is already broken and should run now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix GitHub Actions regarding translations
3 participants