Move XP signal now that observations are updated directly

backend/nature_go/observation/serializers.py

@@ -3,7 +3,6 @@
 from django.contrib.staticfiles import finders
 
 from observation.models import Observation, Species
-from user_profile.signals import xp_gained
 
 class ObservationSerializer(serializers.ModelSerializer):
     user = serializers.ReadOnlyField(source='user.username')
@@ -14,11 +13,6 @@ class Meta:
         model = Observation
         fields = ['id', 'user', 'image', 'organ', 'species', 'location', 'datetime', 'identification_response', 'xp']
 
-    def update(self, instance, validated_data):
-        super().update(instance, validated_data)
-        if not instance.xp and instance.species:
-            xp_gained.send(sender=instance.__class__, instance=instance)
-        return instance
 
 class SpeciesSerializer(serializers.ModelSerializer):
     illustration = Base64ImageField()

backend/nature_go/observation/views.py

@@ -9,6 +9,7 @@
 from observation.serializers import ObservationSerializer, SpeciesSerializer
 from observation.permissions import IsOwner, IsAdminOrReadOnly
 from observation import identification
+from user_profile.signals import xp_gained
 
 logger = logging.getLogger(__name__)
 
@@ -151,4 +152,7 @@ def update(self, request, *args, **kwargs):
             defaults=species_data)
         instance.species = species
         instance.save()
+        if not instance.xp and instance.species:
+            xp_gained.send(sender=instance.__class__, instance=instance)
+
         return Response(ObservationSerializer(instance).data)