Update instance directly in observation update

eleurent · Oct 15, 2023 · b7968ec · b7968ec
1 parent dbabb0b
commit b7968ec
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/backend/nature_go/observation/views.py b/backend/nature_go/observation/views.py
@@ -149,8 +149,6 @@ def update(self, request, *args, **kwargs):
         species, created = Species.objects.update_or_create(
             scientificNameWithoutAuthor=species_data['scientificNameWithoutAuthor'],
             defaults=species_data)
-
-        serializer = ObservationSerializer(instance, data=dict(species=species.id))
-        if serializer.is_valid(raise_exception=True):
-            serializer.save()
-        return Response(serializer.data)
+        instance.species = species
+        instance.save()
+        return Response(ObservationSerializer(instance).data)