Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Project Creation #1

Closed
danrivett opened this issue Feb 22, 2020 · 1 comment
Closed

Initial Project Creation #1

danrivett opened this issue Feb 22, 2020 · 1 comment
Assignees
@danrivett

Comments

@danrivett
Copy link
Contributor

This task tracks the initial project creation.

It's a bit of a monolithic issue, but currently there's only me working on this so there's less reason to.
@danrivett danrivett self-assigned this Feb 22, 2020
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Forking without history commitlint-jira 1.3.0 (https://github.co…
b5b1330 
…m/Gherciu/commitlint-jira) at commit 9d0fdc5.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Replacing all occurrences of 'jira' with 'github' as we're going…
17834fd 
… to convert it to work similarly but for GitHub Issues instead of Jira Issues.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updated the license to add a reference to commitlink-jira which …
80e358b 
…this repository has been cloned from.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Temporarily disabling the GitHub Action whilst it's been repurpo…
e2c0912 
…sed as well as disabling the commitlint checking until we configure it as per our rules.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Removing funding configuration.
e9b1a04
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Replacing 'Jira' references with 'GitHub' references.
9bdbb9f
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Replacing 'JIRA' references with 'GITHUB' references.
29bb26f
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updating README.md with better description.
b607be2
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Renaming files and directories to change 'jira' to 'github'.
2bed08d
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updated package versions to remove 26 vulnerabilities rated 'high'.
e7376a9
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Adding clean commands.
131c6c5
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updated individual package dependency versions.
6f5bb60
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Adding a convenience script to clean and build everything and ru…
9de43b5 
…n all tests. Must be a more idiomatic way by updating package.json, but not sure, so committing this for now.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Removing status rule.
327151d
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) WIP: Updating parser tests for new expected rules.
69c5354
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Disable warning about missing extensions for ts imports.
a10d35c
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Reenabling the semi-colon end of statement requirement because i…
23c7053 
…t's just less confusing, for prettier especially.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Initial changes to commitlint-github-utils.
0262ca6
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Widening line length to 120 characters.
7e7e57f
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updating line formatting for commitlint-github-utils after widen…
b9ccd6f 
…ing allowed line length.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Initial changes to commitlint-config-github.
9ab682d
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updating TypeScript to 3.7.5 as well as ts-loader and webpack to…
fa5a621 
… latest versions.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updating tsconfig.json to switch target to 'ES2018' in order to …
cf074b2 
…support the nullable operator.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updating parser to support WIP comments without an issue number,…
6c0ee38 
… since by definition they are temporary and so should only exist on feature branches.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Adding support for passing parserOptions to the parser to suppor…
de1def4 
…t customized rules.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Adding support for returning the unparsed issueNumbers to be abl…
1e2bbf7 
…e to distinguish missing vs invalid issue numbers.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Implement working parseCommitMessage() method.
0166d16
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Removing old non-applicable rules and implemented githubIssueNum…
eaf4822 
…berMissingRuleResolver and githubIssueNumberFormatRuleResolver rules.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Adding new rule: githubIssueNumberFormatRuleResolver.
91a4319
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Re-enabling the GitHub Action to build and test on push.
cc5eb53
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Re-enabling the GitHub Action to build and test on push.
d357dca
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Switching to fixed mode for lerna to simplify things by keeping …
3c70b79 
…the package versions in step with each other since there aren't many packages so simplest this way.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updating READMEs for individual packages to remove broken image …
eefda70 
…link.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updating plugin references in listed commitlint configuration to…
a2851aa 
… reference new scoped package names.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updating LICENSE formatting to match MIT license placeholder so …
aa09ebb 
…it can be auto-detcted.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updating LICENSE formatting to match MIT license placeholder so …
089ea4f 
…it can be auto-detcted.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Update linting and prettier config and fixing minor issues.
570fc42
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updating GitHub Action to not just build and test but also lint …
bc1cb4a 
…the code and commit messages.
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updating linting config and ignored minor warning in test code.
7bd24f2
danrivett added a commit that referenced this issue Feb 22, 2020
@danrivett
(#1) Updating GitHub Action to not just build and test but also lint …
d5141f7 
…the code and commit messages.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Updating linting config and ignored minor warning in test code.
79c4c08
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Updating GitHub Action to not just build and test but also lint …
bc13768 
…the code and commit messages.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Updating linting config and also fixing existing linting errors …
99331b2 
…missed.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Updating GitHub Action to not just build and test but also lint …
a468a07 
…the code and commit messages.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Updating linting config and also fixing existing linting errors …
d11833b 
…missed.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Updating GitHub Action to not just build and test but also lint …
1cfd42e 
…the code and commit messages.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Updating linting config and also fixing existing linting errors …
0dc6011 
…missed.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Updating GitHub Action to not just build and test but also lint …
115e606 
…the code and commit messages.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Adding GitHub Action to validate PRs too and to prohibit WIP com…
d86da15 
…mits in PRs to prevent them from being merged.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) WIP: Adding GitHub Action to validate PRs too and to prohibit WI…
46bb582 
…P commits in PRs to prevent them from being merged.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Attempting to fix an issue where commitlint couldn't validate th…
1bc2d75 
…e commit messages because the PR branch was checked out as a detached head, see error below:

[error]error running commitlint
fatal: ambiguous argument '46bb5821095a7e8e1ffd48f4697eec3c593c9b24^1..46bb582': unknown revision or path not in the working tree.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Updating node dependencies on ourself to use the published versi…
181ce01 
…on as local file references does not appear to be working when run from a GitHub PR action.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Updating commitlint action prefix to remove GITHUB_WORKSPACE fro…
c34bd1e 
…m the beginning as trying to see why it's not failing with a WIP commit in this PR.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Adding GitHub Action to validate PRs too and to prohibit WIP com…
cc25f8c 
…mits in PRs to prevent them from being merged.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Attempting to fix an issue where commitlint couldn't validate th…
b4e6391 
…e commit messages because the PR branch was checked out as a detached head, see error below:

[error]error running commitlint
fatal: ambiguous argument '46bb5821095a7e8e1ffd48f4697eec3c593c9b24^1..46bb582': unknown revision or path not in the working tree.
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Attempting to fix an issue where commitlint couldn't validate th…
8ac9e0b 
…e commit messages because the PR branch was checked out as a detached head.

The error we received is below:

  error running commitlint
  fatal: ambiguous argument '46bb5821095a7e8e1ffd48f4697eec3c593c9b24^1..46bb582': unknown revision or path not in the working tree.

This was solved using a solution reported here: actions/checkout#124 (comment)
danrivett added a commit that referenced this issue Feb 23, 2020
@danrivett
(#1) Fixing an issue where commitlint couldn't validate the commit me…
facde3e 
…ssages because the PR branch was checked out as a detached head.

The error we received is below:

  error running commitlint
  fatal: ambiguous argument '46bb5821095a7e8e1ffd48f4697eec3c593c9b24^1..46bb582': unknown revision or path not in the working tree.

This was solved using a solution reported here: actions/checkout#124 (comment)
@danrivett
Copy link
Contributor Author

Closing this Issue off as the basic implementation is working and has been published to NPM.

Also adding a GitHub action to validate pushes and PRs which was tested using PR: #2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danrivett danrivett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danrivett