Skip to content

Commit

Permalink
Merge pull request #260 from elisasre/push-update-1712118978
Browse files Browse the repository at this point in the history
[repo-updater] push golangcilint.yml
  • Loading branch information
jauru authored Apr 3, 2024
2 parents b799b99 + 1db4a59 commit c172cc3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 4 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ linters:

issues:
max-same-issues: 0
exclude-rules:
- path: '(.+)_test\.go'
linters:
- bodyclose
linters-settings:
errcheckjson:
# report warning when checking error when not required
Expand Down
4 changes: 0 additions & 4 deletions ratelimit_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ func setupRouter(mw gin.HandlerFunc) *gin.Engine {
return r
}

//nolint:bodyclose
func TestRedisRateLimiterAlways(t *testing.T) {
s, err := miniredis.Run()
require.Equal(t, err, nil)
Expand Down Expand Up @@ -67,7 +66,6 @@ func TestRedisRateLimiterAlways(t *testing.T) {
require.Equal(t, "0", w3.Result().Header.Get(ratelimitRemaining))
}

//nolint:bodyclose
func TestRedisRateLimiterSkip(t *testing.T) {
s, err := miniredis.Run()
require.Equal(t, err, nil)
Expand Down Expand Up @@ -102,7 +100,6 @@ func TestRedisRateLimiterSkip(t *testing.T) {
}
}

//nolint:bodyclose
func TestRedisRateLimiterForce(t *testing.T) {
s, err := miniredis.Run()
require.Equal(t, err, nil)
Expand Down Expand Up @@ -146,7 +143,6 @@ func TestRedisRateLimiterForce(t *testing.T) {
require.Equal(t, "", w2.Result().Header.Get(ratelimitRemaining))
}

//nolint:bodyclose
func TestRedisRateLimiterNil(t *testing.T) {
nilLimiter := RedisRateLimiter(nil,
func(c *gin.Context) (key string, limit *int, err error) {
Expand Down
2 changes: 1 addition & 1 deletion service/module/httpserver/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func TestServerShutdownTimeout(t *testing.T) {
wg.Go(srv.Run)

go func() {
resp, err := http.Get(url) //nolint:gosec,bodyclose
resp, err := http.Get(url) //nolint:gosec
assert.NoError(t, err)
io.Copy(io.Discard, resp.Body) //nolint: errcheck
}()
Expand Down

0 comments on commit c172cc3

Please sign in to comment.