-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #23 from elisasre/redisratelimiter
add redis ratelimiter tests
- Loading branch information
Showing
4 changed files
with
168 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,145 @@ | ||
| package common | ||
|
|
||
| import ( | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
|
|
||
| "github.com/alicebob/miniredis/v2" | ||
| "github.com/gin-gonic/gin" | ||
| "github.com/go-redis/redis/v8" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func setupRouter(mw gin.HandlerFunc) *gin.Engine { | ||
| r := gin.New() | ||
| r.GET("/healthz", mw, func(c *gin.Context) { | ||
| c.String(http.StatusOK, "ok") | ||
| }) | ||
| return r | ||
| } | ||
|
|
||
| //nolint:bodyclose | ||
| func TestRedisRateLimiterAlways(t *testing.T) { | ||
| s, err := miniredis.Run() | ||
| require.Equal(t, err, nil) | ||
| redisClient := redis.NewClient(&redis.Options{ | ||
| Addr: s.Addr(), | ||
| }) | ||
| alwaysRateLimiter := RedisRateLimiter(redisClient, | ||
| func(c *gin.Context) (key string, limit *int, err error) { | ||
| return "test-user", Int(2), nil | ||
| }, | ||
| func(c *gin.Context, err error) bool { | ||
| if err != nil { | ||
| t.Log(err) | ||
| } | ||
| return false | ||
| }, | ||
| ) | ||
|
|
||
| router := setupRouter(alwaysRateLimiter) | ||
| require.Equal(t, err, nil) | ||
|
|
||
| w := httptest.NewRecorder() | ||
| req, err := http.NewRequest("GET", "/healthz", nil) | ||
| require.Equal(t, err, nil) | ||
| router.ServeHTTP(w, req) | ||
| require.Equal(t, 200, w.Code) | ||
| require.Equal(t, "ok", w.Body.String()) | ||
| require.Equal(t, "2", w.Result().Header.Get(ratelimitLimit)) | ||
| require.Equal(t, "1", w.Result().Header.Get(ratelimitRemaining)) | ||
|
|
||
| w2 := httptest.NewRecorder() | ||
| router.ServeHTTP(w2, req) | ||
| require.Equal(t, 200, w2.Code) | ||
| require.Equal(t, "ok", w2.Body.String()) | ||
| require.Equal(t, "2", w2.Result().Header.Get(ratelimitLimit)) | ||
| require.Equal(t, "0", w2.Result().Header.Get(ratelimitRemaining)) | ||
|
|
||
| w3 := httptest.NewRecorder() | ||
| router.ServeHTTP(w3, req) | ||
| require.Equal(t, 429, w3.Code) | ||
| require.Equal(t, `{"code":429,"message":"rate limit exceeded"}`, w3.Body.String()) | ||
| require.Equal(t, "2", w3.Result().Header.Get(ratelimitLimit)) | ||
| require.Equal(t, "0", w3.Result().Header.Get(ratelimitRemaining)) | ||
| } | ||
|
|
||
| //nolint:bodyclose | ||
| func TestRedisRateLimiterSkip(t *testing.T) { | ||
| s, err := miniredis.Run() | ||
| require.Equal(t, err, nil) | ||
| redisClient := redis.NewClient(&redis.Options{ | ||
| Addr: s.Addr(), | ||
| }) | ||
|
|
||
| skipRateLimiter := RedisRateLimiter(redisClient, | ||
| func(c *gin.Context) (key string, limit *int, err error) { | ||
| return "", nil, nil | ||
| }, | ||
| func(c *gin.Context, err error) bool { | ||
| if err != nil { | ||
| t.Log(err) | ||
| } | ||
| return false | ||
| }, | ||
| ) | ||
|
|
||
| router := setupRouter(skipRateLimiter) | ||
| require.Equal(t, err, nil) | ||
| for i := 1; i < 5; i++ { | ||
| w := httptest.NewRecorder() | ||
| req, err := http.NewRequest("GET", "/healthz", nil) | ||
| require.Equal(t, err, nil) | ||
| router.ServeHTTP(w, req) | ||
| require.Equal(t, 200, w.Code) | ||
| require.Equal(t, "ok", w.Body.String()) | ||
|
|
||
| require.Equal(t, "", w.Result().Header.Get(ratelimitLimit)) | ||
| require.Equal(t, "", w.Result().Header.Get(ratelimitRemaining)) | ||
| } | ||
| } | ||
|
|
||
| //nolint:bodyclose | ||
| func TestRedisRateLimiterForce(t *testing.T) { | ||
| s, err := miniredis.Run() | ||
| require.Equal(t, err, nil) | ||
| redisClient := redis.NewClient(&redis.Options{ | ||
| Addr: s.Addr(), | ||
| }) | ||
|
|
||
| forceRateLimiter := RedisRateLimiter(redisClient, | ||
| func(c *gin.Context) (key string, limit *int, err error) { | ||
| return "test-user", Int(2), nil | ||
| }, | ||
| func(c *gin.Context, err error) bool { | ||
| if err != nil { | ||
| t.Log(err) | ||
| } | ||
| c.JSON(http.StatusBadRequest, | ||
| ErrorResponse{Code: http.StatusBadRequest, Message: err.Error()}, | ||
| ) | ||
| c.Abort() | ||
| return true | ||
| }, | ||
| ) | ||
| router := setupRouter(forceRateLimiter) | ||
|
|
||
| w := httptest.NewRecorder() | ||
| req, err := http.NewRequest("GET", "/healthz", nil) | ||
| require.Equal(t, err, nil) | ||
| router.ServeHTTP(w, req) | ||
| require.Equal(t, 200, w.Code) | ||
| require.Equal(t, "ok", w.Body.String()) | ||
| require.Equal(t, "2", w.Result().Header.Get(ratelimitLimit)) | ||
| require.Equal(t, "1", w.Result().Header.Get(ratelimitRemaining)) | ||
|
|
||
| s.SetError("server is unavailable") | ||
|
|
||
| w2 := httptest.NewRecorder() | ||
| router.ServeHTTP(w2, req) | ||
| require.Equal(t, 400, w2.Code) | ||
| require.Equal(t, `{"code":400,"message":"server is unavailable"}`, w2.Body.String()) | ||
| require.Equal(t, "", w2.Result().Header.Get(ratelimitLimit)) | ||
| require.Equal(t, "", w2.Result().Header.Get(ratelimitRemaining)) | ||
| } |