Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slog utils #107

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Add slog utils #107

merged 1 commit into from
Oct 30, 2023

Conversation

heppu
Copy link
Contributor

@heppu heppu commented Oct 27, 2023

No description provided.

@heppu heppu requested review from juho9000, zetaab and kraashen October 27, 2023 09:14
@elisa-codecov
Copy link

elisa-codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #107 (d86f6b7) into main (2b4d699) will increase coverage by 2.22%.
The diff coverage is 100.00%.

❗ Current head d86f6b7 differs from pull request most recent head dcb7d9c. Consider uploading reports for the commit dcb7d9c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   60.71%   62.93%   +2.22%     
==========================================
  Files          12       13       +1     
  Lines         784      831      +47     
==========================================
+ Hits          476      523      +47     
  Misses        274      274              
  Partials       34       34
Impacted Files Coverage Δ
log/logger.go 100.00% <100.00%> (ø)

Impacted file tree graph

@heppu heppu force-pushed the feat/slog branch 3 times, most recently from accbad0 to d86f6b7 Compare October 27, 2023 09:30
@heppu heppu changed the title Added slog util Add slog utils Oct 27, 2023
kraashen
kraashen reviewed Oct 30, 2023
View reviewed changes
log/logger.go Show resolved Hide resolved
log/logger.go Outdated Show resolved Hide resolved
@heppu heppu requested a review from kraashen October 30, 2023 10:14
kraashen
kraashen approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@kraashen kraashen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@heppu heppu merged commit 0181b67 into main Oct 30, 2023
@heppu heppu deleted the feat/slog branch October 30, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraashen kraashen kraashen approved these changes

@juho9000 juho9000 Awaiting requested review from juho9000

@zetaab zetaab Awaiting requested review from zetaab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heppu @kraashen