Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preCleanup for integrationtest #435

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Add preCleanup for integrationtest #435

merged 1 commit into from
Nov 19, 2024

Conversation

rofafor
Copy link
Contributor

@rofafor rofafor commented Nov 16, 2024

No description provided.

@rofafor rofafor requested a review from heppu November 16, 2024 13:53
Copy link

elisa-codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 76.12%. Comparing base (3d3f8fd) to head (e3d6b36).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   76.36%   76.12%   -0.24%     
==========================================
  Files          39       39              
  Lines        2276     2283       +7     
==========================================
  Hits         1738     1738              
- Misses        432      437       +5     
- Partials      106      108       +2     
Flag Coverage Δ
unit 76.12% <36.36%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
v2/integrationtest/it_runner.go 35.29% <36.36%> (+0.86%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

@heppu
Copy link
Contributor

heppu commented Nov 18, 2024

Maybe add some tests that validate the reverse behavior.

@rofafor rofafor merged commit ea69ff1 into main Nov 19, 2024
4 of 6 checks passed
@rofafor rofafor deleted the chore/precleanup branch November 19, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants