Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apiVersion #48

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix apiVersion #48

merged 1 commit into from
Jul 9, 2024

Conversation

lvarin
Copy link
Contributor

@lvarin lvarin commented Jul 8, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage
  • I have added docstrings following the Python style guidelines of this project to all new modules, classes, methods and functions are documented with docstrings following; I have updated any previously existing docstrings, if applicable
  • I have updated any sections of the app's documentation that are affected by the proposed changes, if applicable

Summary by Sourcery

This pull request updates the apiVersion in the cloud-registry-deploy.yaml file to ensure compatibility with the current Kubernetes API, addressing potential deployment issues.

  • Bug Fixes:
    • Updated the apiVersion in the cloud-registry-deploy.yaml file from extensions/v1beta1 to apps/v1 to ensure compatibility with the current Kubernetes API.

Copy link

sourcery-ai bot commented Jul 8, 2024

Reviewer's Guide by Sourcery

This pull request updates the Kubernetes deployment template to use a more recent API version. Specifically, it changes the apiVersion from extensions/v1beta1 to apps/v1 in the cloud-registry-deploy.yaml file. This change ensures compatibility with newer Kubernetes versions, as extensions/v1beta1 is deprecated.

File-Level Changes

Files Changes
deployment/templates/cloud-registry-deploy.yaml Updated the Kubernetes deployment template to use the apps/v1 API version.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lvarin - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@trispera trispera self-requested a review July 9, 2024 04:52
Copy link
Member

@trispera trispera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trispera trispera merged commit 6e4d545 into dev Jul 9, 2024
3 of 4 checks passed
@trispera trispera deleted the apiVersion-fix branch July 9, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants