Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use resource binaries on Series.to_list for strings #346

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Use resource binaries on Series.to_list for strings #346

merged 3 commits into from
Sep 20, 2022

Conversation

josevalim
Copy link
Member

Still WIP, depends on rusterlium/rustler#485.

@josevalim josevalim mentioned this pull request Sep 15, 2022
Merged
@josevalim
Copy link
Member Author

If you folks are OK with cargo temporarily having a Git dependency, this is good to go.

Compared to the latest release, main encodes a utf-8 series to list 10x faster and uses twice less memory.

@josevalim josevalim marked this pull request as ready for review September 18, 2022 14:37
@josevalim
Copy link
Member Author

Note: this PR also has the foundation so we get zero-copy interop with Nx.

philss
philss approved these changes Sep 18, 2022
View reviewed changes
Copy link
Contributor

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you folks are OK with cargo temporarily having a Git dependency, this is good to go.

Compared to the latest release, main encodes a utf-8 series to list 10x faster and uses twice less memory.

Awesome! :D
I'm OK with using the GitHub version :)

cigrainger
cigrainger approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@cigrainger cigrainger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible. I'm definitely okay with the git dependency!

@josevalim josevalim merged commit 6b7e110 into main Sep 20, 2022
@josevalim josevalim deleted the jv-resource-binary branch September 20, 2022 06:38
@josevalim
Copy link
Member Author

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philss philss philss approved these changes

@cigrainger cigrainger cigrainger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josevalim @philss @cigrainger