Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add as possible return type of aggregate functions (#411) #412

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

linusdm
Copy link
Contributor

@linusdm linusdm commented Nov 16, 2022

Add nil as possible return type ofo aggregate functions:

  • sum
  • min
  • max
  • mean
  • median
  • variance
  • standard_deviation
  • quantile

Each one of these functions can return nil when invoked with an empty Series.

@linusdm
Copy link
Contributor Author

linusdm commented Nov 16, 2022

I wasn't able to compile the project locally, so I'm not sure if all tests still run. I've tried all aggregation functions listed, to see whether they actually return nil.

@philss philss merged commit 720cd30 into elixir-explorer:main Nov 16, 2022
@philss
Copy link
Contributor

philss commented Nov 16, 2022

@linusdm thank you! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants