Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DF describe #444

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2022

Initial implementation of #157

Cristine Guadelupe added 2 commits December 1, 2022 21:14
Copy link
Contributor

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for the first version of describe/1 :shipit:

Congrats on your first contribution to Explorer! 🎉 😃

Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot! 🎉 Just one minor comment and we can ship it!

Cristine Guadelupe and others added 2 commits December 2, 2022 13:31
@josevalim josevalim merged commit 710827b into elixir-explorer:main Dec 2, 2022
@josevalim
Copy link
Member

@philss could you please open up an issue on polars and ask if they would also consider adding nulls count to describe?

@ghost ghost deleted the cg-df-describe branch December 2, 2022 18:27
@philss
Copy link
Contributor

philss commented Dec 4, 2022

@josevalim they already had an issue about this, so I asked there: pola-rs/polars#4068
Seems that the Python version shows this information.

liamdiprose pushed a commit to liamdiprose/explorer that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants