Add more integer dtypes #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it's possible to read files that contain those types.
This also removes some conversion, and simplify things in the Rust side.
josevalim
approved these changes
Dec 13, 2023
|
Also don't forget to add to your todo list the refactoring of iotype. :) |
This was referenced Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for signed and unsigned integer datatypes. There are now 8 different dtypes for integers, and they have 8, 16, 32 or 64 bits in size.
The idea is to follow the same naming from Nx.
{:s, size}is for signed integers, and{:u, size}is for the unsigned.In this PR I'm adding only the new dtypes. The
:integerdtype remains, and I should "rename" it - to{:s, 64}- in another PR.PS: there are some work to be done in the area of projecting the dtypes of "out dfs" that I plan to do in another PR as well.