Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add :null tests for data frame from ndjson #811

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Add :null tests for data frame from ndjson #811

merged 1 commit into from
Jan 10, 2024

Conversation

lkarthee
Copy link
Member

Fix for #783

cigrainger
cigrainger approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@cigrainger cigrainger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! <3

@cigrainger cigrainger merged commit 52f4cf7 into elixir-explorer:main Jan 10, 2024
3 checks passed
@lkarthee lkarthee deleted the ndjson_df_nil_test_cases branch January 10, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cigrainger cigrainger cigrainger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkarthee @cigrainger