Several fixes:

* Fix version dropdown * Do not crash package if Hex package information is not available
elixir-lang · Jan 11, 2022 · 30ddadd · 30ddadd
1 parent 0d4ca8b
commit 30ddadd
Show file tree

Hide file tree

Showing 17 changed files with 32 additions and 29 deletions.
diff --git a/assets/js/handlebars/templates/versions-dropdown.handlebars b/assets/js/handlebars/templates/versions-dropdown.handlebars
@@ -1,5 +1,5 @@
 <form autocomplete="off">
-  <select class="sidebar-projectVersionsDropdown" dir="rtl">
+  <select class="sidebar-projectVersionsDropdown">
     {{#each nodes}}
       <option translate="no" value="{{url}}"{{#if isCurrentVersion}} selected disabled{{/if}}>
         {{version}}

diff --git a/assets/js/quick-switch.js b/assets/js/quick-switch.js
@@ -36,8 +36,10 @@ export function initialize () {
 }
 
 function addEventListeners () {
-  qs(QUICK_SWITCH_LINK_SELECTOR).addEventListener('click', event => {
-    openQuickSwitchModal()
+  qsAll(QUICK_SWITCH_LINK_SELECTOR).forEach(element => {
+    element.addEventListener('click', event => {
+      openQuickSwitchModal()
+    })
   })
 }
 

diff --git a/assets/js/settings.js b/assets/js/settings.js
@@ -1,5 +1,5 @@
 import settingsModalBodyTemplate from './handlebars/templates/settings-modal-body.handlebars'
-import { qs } from './helpers'
+import { qs, qsAll } from './helpers'
 import { openModal } from './modal'
 import { shouldUseNightMode } from './night'
 import { settingsStore } from './settings-store'
@@ -31,8 +31,10 @@ export function initialize () {
 }
 
 function addEventListeners () {
-  qs(SETTINGS_LINK_SELECTOR).addEventListener('click', event => {
-    openSettingsModal()
+  qsAll(SETTINGS_LINK_SELECTOR).forEach(element => {
+    element.addEventListener('click', event => {
+      openSettingsModal()
+    })
   })
 }
 

diff --git a/assets/js/tooltips/hints.js b/assets/js/tooltips/hints.js
@@ -170,11 +170,7 @@ export function extractFunctionHint (element) {
  * @returns {Hint}
  */
 export function extractModuleHint (content) {
-  const heading = content.querySelector('h1')
-  // Get just the text content ignoring other elements.
-  while (heading.firstElementChild) {
-    heading.removeChild(heading.firstElementChild)
-  }
+  let heading = content.querySelector('h1 span')
   const title = heading.textContent
 
   const firstParagraph = content.querySelector('#moduledoc p')

diff --git a/assets/less/sidebar.less b/assets/less/sidebar.less
@@ -80,14 +80,16 @@
 
   .sidebar-projectVersionsDropdown {
     cursor: pointer;
+    position: relative;
     margin: 0;
-    padding: 0 12px 0 0;
+    padding: 0 0 0 12px;
     border: none;
     -moz-appearance: none;
     -webkit-appearance: none;
     appearance: none;
     background-color: transparent;
     color: @white;
+    z-index: 2;
 
     option {
       color: initial;
@@ -100,11 +102,12 @@
 
   .sidebar-projectVersion form::after {
     position: absolute;
-    right: 0;
-    top: 1px;
+    left: 0;
+    top: 2px;
     content: '\25BC';
-    z-index: -1;
+    z-index: 1;
     font-size: 8px;
+    color: @white;
   }
 
   .sidebar-projectVersionsDropdown::-ms-expand {

diff --git a/assets/less/variables/common.less b/assets/less/variables/common.less
@@ -21,7 +21,7 @@
 @nightBackground: #030913; // gray 900
 @nightCodeBackground: #0D1829; // gray 800
 @nightCodeBorder: #304254; // gray 600
-@nightTextBody: #BAC5D0;
+@nightTextBody: #CAD5E0; // gray 200
 @nightTextHeaders: #F0F5F9; // gray 50
 @nightHeader: #0D1829; // gray 800
 @nightDeprecated: #333019;

diff --git a/assets/test/tooltips/hints.spec.js b/assets/test/tooltips/hints.spec.js
@@ -5,7 +5,7 @@ describe('hints extraction', () => {
     const modulePageObject = parseHTML(`
       <div>
         <h1>
-          Some module <small class="app-vsn">(ExDoc v0.0.1)</small>
+          <span>Some module</span> <small class="app-vsn">(ExDoc v0.0.1)</small>
 
           <a href="https://github.com/" title="View Source" class="view-source" rel="help">
             <i class="ri-code-s-slash-line" aria-hidden="true"></i>

diff --git a/formatters/html/dist/app-008923d27aea1c274153.js b/formatters/html/dist/app-008923d27aea1c274153.js
diff --git a/...t/app-973561a99a0985d496b3.js.LICENSE.txt → ...t/app-008923d27aea1c274153.js.LICENSE.txt b/...t/app-973561a99a0985d496b3.js.LICENSE.txt → ...t/app-008923d27aea1c274153.js.LICENSE.txt
diff --git a/formatters/html/dist/app-973561a99a0985d496b3.js b/formatters/html/dist/app-973561a99a0985d496b3.js
diff --git a/formatters/html/dist/elixir-925acc81db1bc46f1558.css b/formatters/html/dist/elixir-925acc81db1bc46f1558.css
diff --git a/formatters/html/dist/elixir-e03c3d7588cc75980d77.css b/formatters/html/dist/elixir-e03c3d7588cc75980d77.css
diff --git a/formatters/html/dist/erlang-af4097a665e030ec41c8.css b/formatters/html/dist/erlang-af4097a665e030ec41c8.css
diff --git a/formatters/html/dist/erlang-d0a1de5e2f9743ebbcf5.css b/formatters/html/dist/erlang-d0a1de5e2f9743ebbcf5.css
diff --git a/lib/ex_doc/formatter/html/templates/extra_template.eex b/lib/ex_doc/formatter/html/templates/extra_template.eex
@@ -1,8 +1,8 @@
 <%= head_template(config, %{title: node.title, type: :extra}) %>
 <%= sidebar_template(config, nodes_map) %>
 
-<h1 id="content">
-  <%= node.title_content %>
+<h1>
+  <span><%= node.title_content %></span>
   <%= settings_button_template() %>
   <%= if node.source_url do %>
     <a href="<%= node.source_url %>" title="View Source" class="view-source" rel="help">

diff --git a/lib/ex_doc/formatter/html/templates/not_found_template.eex b/lib/ex_doc/formatter/html/templates/not_found_template.eex
@@ -1,8 +1,8 @@
 <%= head_template(config, %{title: "404", type: :extra}) %>
 <%= sidebar_template(config, nodes_map) %>
 
-<h1 id="content">
-  Page not found
+<h1>
+  <span>Page not found</span>
   <%= settings_button_template() %>
 </h1>
 

diff --git a/lib/ex_doc/formatter/html/templates/search_template.eex b/lib/ex_doc/formatter/html/templates/search_template.eex
@@ -2,8 +2,8 @@
 <%= sidebar_template(config, nodes_map) %>
 
 <div id="search">
-  <h1 id="content">
-    Page not found
+  <h1>
+    <span>Page not found</span>
     <%= settings_button_template() %>
   </h1>