Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the Preview height was not recalculated when window was resized #1890

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: the Preview height was not recalculated when window was resized #1890

merged 1 commit into from
Apr 10, 2024

Conversation

ThaddeusJiang
Copy link
Contributor

bug:

I found a bug. If we resize the window (for example, by making it thinner), we don't recompute the new iframe height.
from fix: #1884 (comment)

fixed:

CleanShot 2024-04-10 at 16 07 33

@josevalim josevalim merged commit da47bc4 into elixir-lang:main Apr 10, 2024
4 checks passed
@josevalim
Copy link
Member

This is lovely, thank you! 💚 💙 💜 💛 ❤️

@ThaddeusJiang ThaddeusJiang deleted the feat/iframe-resize branch April 10, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThaddeusJiang @josevalim