Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkspaceSymbols index after successful build #263

Merged
merged 6 commits into from
May 29, 2020
Merged

WorkspaceSymbols index after successful build #263

merged 6 commits into from
May 29, 2020

Conversation

axelson
Copy link
Member

@axelson axelson commented May 26, 2020

Previously WorkspaceSymbols depended on a side-effect of running Dialyzer:
#110 (comment)

Now that the Build step loads all modules (added in #227) we need to change the WorkspaceSymbols index to be rebuilt after a successful compile.

Previously WorkspaceSymbols depended on a side-effect of running Dialyzer:
#110 (comment)

Now that the Build step loads all modules (added in #227) we need to change the
WorkspaceSymbols index to be rebuilt after a successful compile.
Allow WorkspaceSymbol to have it's own instance of the GenServer for the test by
being parameterized by the server's registered name
@axelson
Copy link
Member Author

axelson commented May 26, 2020

Need to fix the test error:

** (Mix.Error) Cannot access build without an application name, please ensure you are in a directory with a mix.exs file and it defines an :app name under the project configuration

    (mix) lib/mix.ex:323: Mix.raise/1

    (mix) lib/mix/project.ex:521: Mix.Project.compile_path/1

    (mix) lib/mix/tasks/compile.all.ex:24: anonymous fn/1 in Mix.Tasks.Compile.All.run/1

axelson added 4 commits May 29, 2020 07:20
This is probably necessary now because workspace symbols is running earlier
@axelson axelson merged commit fb6241c into elixir-lsp:master May 29, 2020
@axelson axelson deleted the workspace-symbols-broken-with-dialyzer-disabled branch May 29, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant