Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference lookup perf improvement and table schema versioning #112

Closed
wants to merge 2 commits into from

Conversation

sineed
Copy link
Contributor

@sineed sineed commented Jul 14, 2023

depends on elixir-tools/gen_lsp#37

The fix was simple to replace :dets.select/2 in favor of :dets.lookup/2. But it required a change in how references are stored. So the mechanism to clear dets table and trigger recompilation was added. It should recompile initially as the current table schema version is nil and every time the schema version value (for example, @reference_table_schema_version_value) is changed. I covered both symbol and reference tables.

This will also conflict with the hovering PR as I moved symbol logic to its own GenServer there but it should be not a big deal to resolve here or there

@mhanberg
Copy link
Collaborator

mhanberg commented Aug 1, 2023

I switched the symbol/ref tables to use sqlite3 instead, so now lookups are very fast.

@mhanberg mhanberg closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants