Reference lookup perf improvement and table schema versioning #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on elixir-tools/gen_lsp#37
The fix was simple to replace
:dets.select/2
in favor of:dets.lookup/2
. But it required a change in how references are stored. So the mechanism to clear dets table and trigger recompilation was added. It should recompile initially as the current table schema version isnil
and every time the schema version value (for example,@reference_table_schema_version_value
) is changed. I covered both symbol and reference tables.This will also conflict with the hovering PR as I moved symbol logic to its own GenServer there but it should be not a big deal to resolve here or there