-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Twitter search switch #1003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM outside of adding to .env.example thanks for doing this :)
agent/src/index.ts
Outdated
@@ -335,6 +335,7 @@ export async function initializeClients( | |||
} | |||
|
|||
if (clientTypes.includes("twitter")) { | |||
TwitterClientInterface.enableSearch = getSecret(character, "TWITTER_SEARCH_ENABLE"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this to the .env.example? TWITTER_SEARCH_ENABLE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
…h like the string FALSE
Risks
Low
Background
What does this PR do?
reads and respects TWITTER_SEARCH_ENABLE (from .env or character json)
What kind of change is this?
Improvements (misc. changes to existing features)
Why are we doing this? Any context or related work?
So users don't have to edit source to enable this feature
Documentation changes needed?
My changes require a change to the project documentation.