Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Twitter search switch #1003

Merged
merged 8 commits into from
Dec 12, 2024
Merged

Conversation

odilitime
Copy link
Collaborator

@odilitime odilitime commented Dec 12, 2024

Risks

Low

Background

What does this PR do?

reads and respects TWITTER_SEARCH_ENABLE (from .env or character json)

What kind of change is this?

Improvements (misc. changes to existing features)

Why are we doing this? Any context or related work?

So users don't have to edit source to enable this feature

Documentation changes needed?

My changes require a change to the project documentation.

monilpat
monilpat previously approved these changes Dec 12, 2024
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of adding to .env.example thanks for doing this :)

@@ -335,6 +335,7 @@ export async function initializeClients(
}

if (clientTypes.includes("twitter")) {
TwitterClientInterface.enableSearch = getSecret(character, "TWITTER_SEARCH_ENABLE");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this to the .env.example? TWITTER_SEARCH_ENABLE

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@odilitime
Copy link
Collaborator Author

Screen Shot 2024-12-11 at 11 00 40 PM screenshots for the record

@odilitime odilitime changed the base branch from main to develop December 12, 2024 07:18
@monilpat monilpat merged commit e4dac88 into elizaOS:develop Dec 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants