fix: discord client duplicate function removal #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azep-ninja
changed the title
monilpat
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
N/A
Risks
Low - Removing duplicate function.
Background
What does this PR do?
What kind of change is this?
Bug fix - Removing duplicate _isMessageForMe private function in Discord messages.ts file.
Documentation changes needed?
N/A
Testing
Where should a reviewer start?
Detailed testing steps
Review messages.ts in discord-client to confirm only 1 private _isMessageForMe now exists with same functionality to avoid issues.
N/A
N/A
N/A
N/A