fix: bridge and swap actions context params generation #1524
+48
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odilitime
previously approved these changes
Dec 28, 2024
|
I think there's some duplication of the work done in #1456 but I did my best to merge the best of both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
issue number #1523
Risks
Medium: Changes on two files created compose actions & regenerate the details object
Background
What does this PR do?
This fix ensures that the bridge and swap actions are properly populated with the necessary details required for the bridgeAction and SwapAction handlers. As a result:
Bridge operations will now process the toAddress, token information, and other required parameters without error.
Swap operations will execute successfully with all required data passed to the handler.