Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: twitter usernames can start with numbers #1541

Merged
merged 3 commits into from
Dec 28, 2024
Merged

fix: twitter usernames can start with numbers #1541

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c84b33c
fix number prefixed username, add X brand in messaging
odilitime Dec 28, 2024
ee91a06
Merge branch 'develop' into twitter-fix
odilitime Dec 28, 2024
a378915
Merge branch 'develop' into twitter-fix
odilitime Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/client-twitter/src/environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ import { z } from "zod";
export const DEFAULT_MAX_TWEET_LENGTH = 280;

const twitterUsernameSchema = z.string()
.min(1)
.max(15)
.regex(/^[A-Za-z][A-Za-z0-9_]*[A-Za-z0-9]$|^[A-Za-z]$/, 'Invalid Twitter username format');
.min(4, 'An X/Twitter Username must be at least 4 characters long')
.max(15, 'n X/Twitter Username cannot exceed 15 characters')
.regex(/^[A-Za-z0-9_]*$/, 'n X Username can only contain letters, numbers, and underscores');

export const twitterEnvSchema = z.object({
TWITTER_DRY_RUN: z.boolean(),
TWITTER_USERNAME: z.string().min(1, "Twitter username is required"),
TWITTER_PASSWORD: z.string().min(1, "Twitter password is required"),
TWITTER_EMAIL: z.string().email("Valid Twitter email is required"),
TWITTER_USERNAME: z.string().min(1, "X/Twitter username is required"),
TWITTER_PASSWORD: z.string().min(1, "X/Twitter password is required"),
TWITTER_EMAIL: z.string().email("Valid X/Twitter email is required"),
MAX_TWEET_LENGTH: z.number().int().default(DEFAULT_MAX_TWEET_LENGTH),
TWITTER_SEARCH_ENABLE: z.boolean().default(false),
TWITTER_2FA_SECRET: z.string(),
Expand Down Expand Up @@ -164,7 +164,7 @@ export async function validateTwitterConfig(
.map((err) => `${err.path.join(".")}: ${err.message}`)
.join("\n");
throw new Error(
`Twitter configuration validation failed:\n${errorMessages}`
`X/Twitter configuration validation failed:\n${errorMessages}`
);
}
throw error;
Expand Down
Loading