fix: Seperated imageModelProvider and imageVisionModelProvider for ImageDescriptioServices #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seperated imageModelProvider and imageVisionModelProvider for ImageDescriptioServices
Relates to:
Generating images, and describing images are two different task, therefore, two different types of model providers can be used.
Risks
low
Background
What does this PR do?
Created a seperate ImageVisionModelProvider for image description related services. Before this PR, same vision service should have be used.
What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Documentation changes needed?
character.md, agentruntime.md changed.
Testing
pnpm build
pnpm start
Where should a reviewer start?