Fix embedding calculation for sqlite #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
#251
Risks
There's no risk, this fixes the bug where embeddings/levenshtein_distance just weren't getting calculated correctly in sqlite
Background
What does this PR do?
Add code to correctly calculate embeddings and levenshtein distance with sqlite
What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Use the sqlite adapter and run defaultCharacter
Where should a reviewer start?
Detailed testing steps
None, automtated tests are fine.
Screenshots
Before
After
Deploy Notes
Database changes
Deployment instructions